Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix enum definition not producing N-quoted string on Sql Server #28176

Merged
merged 1 commit into from Apr 11, 2019

Conversation

Projects
None yet
3 participants
@miklcct
Copy link
Contributor

commented Apr 11, 2019

When I tried to use some Chinese characters in an enum definition in schema builder in Sql Server, the check constraint created was wrong, the Chinese characters turned into ? inside the Sql Server.

The check constraint should be created with the values quoted in N'中文測試' form (note the letter N before the quotation mark).

Reference:
https://social.msdn.microsoft.com/Forums/sqlserver/en-US/5d2ea1a2-32e1-4a82-b6e3-17d2b898babc/chinese-characters-issue-with-tsql?forum=transactsql

@driesvints driesvints changed the title fix enum definition not producing N-quoted string on Sql Server [5.8] Fix enum definition not producing N-quoted string on Sql Server Apr 11, 2019

@taylorotwell taylorotwell merged commit 176d5d3 into laravel:5.8 Apr 11, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.