Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] `whereDay` and `whereMonth` inconsistent when passing `int` values #28185

Merged
merged 2 commits into from Apr 11, 2019

Conversation

Projects
None yet
5 participants
@oliversarfas
Copy link
Contributor

commented Apr 11, 2019

Fixes #28184

  • Laravel Version: 5.8.11
  • PHP Version: 7.3.2
  • Database Driver & Version: MySQL 5.7.25

Description:

When using whereDay, or whereMonth, passing an integer produces mixed results based on the current date

Steps To Reproduce:

add a whereDay, or whereMonth to a builder instance, when the date is less than 10th of the month, or the month is less than 10.
Easiest replication is to use now()->month, or now()->day

@oliversarfas oliversarfas changed the title Fix issue #28184 [5.8] Fix issue #28184 `whereDay` and `whereMonth` inconsistent when passing `int` values Apr 11, 2019

@oliversarfas oliversarfas changed the title [5.8] Fix issue #28184 `whereDay` and `whereMonth` inconsistent when passing `int` values [5.8] `whereDay` and `whereMonth` inconsistent when passing `int` values Apr 11, 2019

@BassemN

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

👍

@taylorotwell taylorotwell merged commit 627fa08 into laravel:5.8 Apr 11, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.