[5.8] whereDay and whereMonth inconsistent when passing int values - #28185
Merged
Conversation
oliversarfas
changed the title
whereDay and whereMonth inconsistent when passing int values
oliversarfas
changed the title
whereDay and whereMonth inconsistent when passing int valueswhereDay and whereMonth inconsistent when passing int values
Jamesking56
approved these changes
Apr 11, 2019
MadMikeyB
approved these changes
Apr 11, 2019
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28184
Description:
When using
whereDay, orwhereMonth, passing an integer produces mixed results based on the current dateSteps To Reproduce:
add a
whereDay, orwhereMonthto a builder instance, when the date is less than 10th of the month, or the month is less than 10.Easiest replication is to use
now()->month, ornow()->day