Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix fake dispatcher issue #28238

Merged
merged 1 commit into from Apr 17, 2019

Conversation

Projects
None yet
2 participants
@TBlindaruk
Copy link
Member

commented Apr 16, 2019

Description:
Integration tests proof that it will work with both built-in session guard or any other custom guard whether it has a dispatcher or not.

Note : some build-in guards like Token guard does dispatch any events, hence there is no setDispatcher method or any dispatcher on it.
So there are 2 types of guards.

which I think a contract (interface) is missing here, in order to mark the SessionGuard class or any other custom guard as an event dispatching guard, and enforce setDispatcher and getDispatcher methods on them.)

So the clunky method_exists check won't be needed.

Re-submit: #28131
fixed: #27451

[5.8] Fix fake dispatcher issue
Description:
Integration tests proof that it will work with both built-in session guard or any other custom guard whether it has a dispatcher or not.

Note : some build-in guards like Token guard does dispatch any events, hence there is no `setDispatcher ` method or any dispatcher on it.
So there are 2 types of guards.

which I think a contract (interface) is missing here, in order to mark the SessionGuard class or any other custom guard as an event dispatching guard, and enforce `setDispatcher` and `getDispatcher` methods on them.)

So the clunky `method_exists` check won't be needed.

Re-submit: #28131
fixed: #27451

@TBlindaruk TBlindaruk force-pushed the TBlindaruk:fix-fake-dispatcher-issue branch from e4d0007 to 4a25686 Apr 16, 2019

@taylorotwell taylorotwell merged commit 4a25686 into laravel:5.8 Apr 17, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@taylorotwell

This comment has been minimized.

Copy link
Member

commented Apr 17, 2019

I made a check to not do anything at all if the auth service has not been resolved yet.

@TBlindaruk TBlindaruk deleted the TBlindaruk:fix-fake-dispatcher-issue branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.