[5.8] Fix recursive replacements in Str::replaceArray()

[staudenmeir]

Str::replaceArray() recursively replaces the search value if it appears in the replacements:

Str::replaceArray('?', ['foo?', 'bar'], '?, ?');

// expected: foo?, bar
// actual:   foobar, ?

Laravel uses the method in query exceptions to replace the ? placeholders with the actual bindings. This causes incorrect results if a binding contains a ?.

We can fix it splitting the string and gluing it back together.

Theoretically, this could be a breaking change for users who are relying on recursive replacements. But I don't a see case where you would want this behavior.

Fixes #28245.

[vlakoff]

I should review this code, but are you sure it works when the first replacement doesn't occur at the very beginning?

[vlakoff]

… or when the parts between the replacements are different.

If there is actually such breakage, the tests would have to be improved as well ;)

[vlakoff]

Just in case, refs #12259, though the previous code had the same problem.

[staudenmeir]

@vlakoff Yes, these cases work.