[5.8] Break out password reset credentials into a method

[dwightwatson]

This breaks out the fetching of credentials from a password reset request into a separate method in a similar fashion to how it occurs in the AuthenticatedUsers trait.

My use-case for this is that I'm using Postgres which is case-sensitive by default, so when a user attempts to reset their password but uses capitals then it tells them their account doesn't exist and leaves them confused.

I'm already overriding credentials for authentication in my own app for this. It might be nice to see Laravel Str::lower email addresses out of the box, but as it appears Postgres-specific it might be overkill.

This solution brings SendsPasswordResetEmails into line with AuthenticatesUsers and allows developers, where necessary, to support email normalization.

[devcircus]

I understand the purpose here, but it doesn't seem like "credentials" is the correct method name for "retrieve email address from current request."

[taylorotwell]

@devcircus that is what PasswordBroker calls that array of data.

[devcircus]

Cool. That makes sense.

[bobbybouwmann]

@driesvints @taylorotwell This is a breaking change if you're using Spark. In spark we have the following code:

class PasswordController extends Controller
{
    use SendsPasswordResetEmails, ResetsPasswords {
        SendsPasswordResetEmails::broker insteadof ResetsPasswords;
    }

    // ...
}

Because both traits now have a credentials method we get the following error

Whoops\Exception\ErrorException : Trait method credentials has not been applied, because there are collisions with other trait methods on Laravel\Spark\Http\Controllers\Auth\PasswordController

Can we revert this?

[devcircus]

There should be a way to make this work without reverting.

Edit: maybe not?

[driesvints]

@devcircus another override in Spark needs to be applied like the one already in place.

[devcircus]

10-4. Ive ran into similar situations in various projects so I thought it could be fixed without reverting this.