Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix the remaining issues with registering custom Doctrine types. #28375

Merged
merged 2 commits into from May 1, 2019

Conversation

Projects
None yet
2 participants
@JacksonIV
Copy link
Contributor

commented Apr 30, 2019

This PR removes the TinyInteger type from the core and allows the user to register their own custom Doctrine DBAL types. No connection wil be established by only instantiating the builder class, only as soon as you call the registerCustomDoctrineType method. Therefore it won't cause issues like #28282 anymore.

@taylorotwell taylorotwell merged commit 841a280 into laravel:5.8 May 1, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.