Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix the remaining issues with registering custom Doctrine types. #28375

Merged
merged 2 commits into from
May 1, 2019
Merged

[5.8] Fix the remaining issues with registering custom Doctrine types. #28375

merged 2 commits into from
May 1, 2019

Conversation

jensdenies
Copy link

This PR removes the TinyInteger type from the core and allows the user to register their own custom Doctrine DBAL types. No connection wil be established by only instantiating the builder class, only as soon as you call the registerCustomDoctrineType method. Therefore it won't cause issues like #28282 anymore.

@taylorotwell taylorotwell merged commit 841a280 into laravel:5.8 May 1, 2019
@kevindb
Copy link

kevindb commented Jun 6, 2019

If support for tinyint is being removed from core Laravel, does the documentation ned to be updated to remove references to tinyIncrements , tinyInteger, and unsignedTinyInteger?
https://laravel.com/docs/5.8/migrations#creating-columns

@driesvints
Copy link
Member

driesvints commented Jun 7, 2019

@kevindb tinyint support wasn't removed in general, just the MySQL override introduced by #28214 because of the bug from #28282.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants