Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Modified None And React presets to exclude vue-template-compiler #28389

Merged
merged 2 commits into from May 1, 2019

Conversation

Projects
None yet
3 participants
@morpheus7CS
Copy link
Contributor

commented May 1, 2019

Submitting a pull request to fix the behavior of React and None frontend scaffolding presets as referenced in issue #.

Have added vue-template-compiler to the list of packages excluded by the two, but have refrained from adding vue-template-compiler into Vue Preset. Will amend it if the maintainers find it valuable for it to be included.

morpheus7CS added some commits May 1, 2019

Update None.php
Added vue-template-compiler to the list of packages that need to be removed by the 'php artisan preset none' command.
Update React.php
Added vue-template-compiler to the list of packages that need to be removed by the 'php artisan preset react' command.

@morpheus7CS morpheus7CS referenced this pull request May 1, 2019

Closed

laravel preset none #28384

@taylorotwell taylorotwell merged commit 6b06714 into laravel:5.8 May 1, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jksdn

This comment has been minimized.

Copy link

commented May 9, 2019

The same issue, Laravel 5.8.16

@GrahamCampbell GrahamCampbell changed the title Modified None And React presets to exclude vue-template-compiler [5.8] Modified None And React presets to exclude vue-template-compiler May 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.