Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Change navbar-laravel class for bootstrap classes #28417

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
3 participants
@yuters
Copy link
Contributor

commented May 5, 2019

Bootstrap >=4.1 includes a shadow-sm class which looks pretty close to the one in the navbar-laravel class https://getbootstrap.com/docs/4.3/utilities/shadows/

You could then remove the .navbar-laravel class here:
https://github.com/laravel/laravel/blob/master/resources/sass/app.scss#L10-L13

Change navbar-laravel class for bootstrap classes
Bootstrap >=4.1 includes a `shadow-sm` class which looks pretty close to the one in the `navbar-laravel` class https://getbootstrap.com/docs/4.3/utilities/shadows/

You could then remove the `.navbar-laravel` class here:
https://github.com/laravel/laravel/blob/master/resources/sass/app.scss#L10-L13

@driesvints driesvints changed the title Change navbar-laravel class for bootstrap classes [5.8] Change navbar-laravel class for bootstrap classes May 6, 2019

@driesvints

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Neat. This way we can also remove the code here: https://github.com/laravel/laravel/blob/master/resources/sass/app.scss#L10-L13

We'll have to update the minimum version of bootstrap here as well: https://github.com/laravel/laravel/blob/master/package.json#L14

@taylorotwell taylorotwell merged commit 7c943e5 into laravel:5.8 May 6, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

driesvints referenced this pull request in laravel/laravel May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.