[5.8] Replace first occurrence instead of last for event discovery - #28426
Merged
Merged
Conversation
Contributor
Author
|
Thx @taylorotwell for the quick merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix the previous PR about event discovery : #28421.
The goal is to replace only the first occurrence instead of the last one because this is not the correct behavior.
Here is an example where the previous PR will create a bug :
/appis the project directory./app/app/Listeners/app/FooListener.phpis the listener file path.In this example, the resolved class path was
/app/app/Listeners/FooListener.phpwith the previous PR. This is incorrect as a namespace part is missing.With this PR, the class is correctly resolved as
/app/Listeners/app/FooListener.php.