Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Replace first occurrence instead of last for event discovery #28426

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
2 participants
@paul-thebaud
Copy link
Contributor

commented May 6, 2019

This PR fix the previous PR about event discovery : #28421.

The goal is to replace only the first occurrence instead of the last one because this is not the correct behavior.
Here is an example where the previous PR will create a bug :
/app is the project directory.
/app/app/Listeners/app/FooListener.php is the listener file path.
In this example, the resolved class path was /app/app/Listeners/FooListener.php with the previous PR. This is incorrect as a namespace part is missing.

With this PR, the class is correctly resolved as /app/Listeners/app/FooListener.php.

@taylorotwell taylorotwell merged commit 2b539a3 into laravel:5.8 May 7, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@paul-thebaud

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

Thx @taylorotwell for the quick merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.