Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Don't execute query when ids are empty Arrayable #28432

Merged

Conversation

Projects
None yet
3 participants
@mnabialek
Copy link
Contributor

commented May 7, 2019

Previous condition was met only if $ids were empty array. If they were empty instance of Arrayable (for example collection with no elements) condition was false and query was executed.

mnabialek added some commits May 7, 2019

mnabialek added some commits May 7, 2019

I was wrong 🙊

@taylorotwell taylorotwell merged commit 7f78d95 into laravel:5.8 May 7, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.