[5.8] Add ends_with validation rule#28455
Merged
Merged
Conversation
Contributor
Author
|
If merged, I will open PRs to update the docs and |
jasonmccreary
added a commit
to jasonmccreary/docs
that referenced
this pull request
May 9, 2019
This is in conjunction with PR [#28455](laravel/framework#28455) to the framework.
This was referenced May 9, 2019
Contributor
|
glad it finally got merged 👍 , mine didn't pass #26652 |
Contributor
Author
|
You have to sell it in the PR notes. 😎 You were also missing code for the message replacement. |
Contributor
|
@jasonmccreary totally agree 👌 |
taylorotwell
pushed a commit
to laravel/docs
that referenced
this pull request
May 10, 2019
This is in conjunction with PR [#28455](laravel/framework#28455) to the framework.
m777z
pushed a commit
to m777z/laravel-docs
that referenced
this pull request
Jun 8, 2019
This is in conjunction with PR [#28455](laravel/framework#28455) to the framework.
gdebrauwer
pushed a commit
to gdebrauwer/docs
that referenced
this pull request
Jun 20, 2019
This is in conjunction with PR [#28455](laravel/framework#28455) to the framework.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
starts_withvalidation rule exists, however anends_withdoes not. Given the symmetry between other validation rules as well as thestartsWithandendsWithstring helper methods, why not add it. Infinitely more expressive than the nastyregex:/(foo|bar)$/alternative.Rule attributes are the same as
starts_with, for example: