Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Provide notification callback with Swift message #28535

Merged
merged 1 commit into from May 15, 2019

Conversation

Projects
None yet
2 participants
@dwightwatson
Copy link
Contributor

commented May 15, 2019

This is an improved approach to #28534 which provides developers direct access to the underlying Swift message before it is fired off. The use-case for the earlier PR was to allow adding headers to the message (for tracking/analytics) but this is a more flexible solution with greater control.

In addition, this approach mimics withSwiftMessage($callback) which mailables have, so it should be familiar for people who are already using that for those reasons. As mentioned in the other PR there has been chatter about supporting custom headers for notification mail (laravel/ideas#475) and this provides that functionality.

@taylorotwell taylorotwell merged commit 5de1d43 into laravel:5.8 May 15, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.