Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] BusFake::pipeThrough() returns $this #28564

Merged
merged 1 commit into from May 17, 2019

Conversation

Projects
None yet
2 participants
@shadoWalker89
Copy link
Contributor

commented May 17, 2019

The real implementation returns $this to allow chaining.
The fake one should do the same to avoid breaking tests when using the fake dispatcher.

@GrahamCampbell GrahamCampbell merged commit 06243df into laravel:5.8 May 17, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GrahamCampbell

This comment has been minimized.

Copy link
Member

commented May 17, 2019

Thanks. :)

@shadoWalker89 shadoWalker89 deleted the shadoWalker89:patch-3 branch May 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.