Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix Eloquent UPDATE queries with alias #28607

Merged
merged 1 commit into from May 25, 2019

Conversation

Projects
None yet
2 participants
@staudenmeir
Copy link
Contributor

commented May 24, 2019

#26031 qualified UPDATED_AT timestamps to fix ambiguity issues.

This doesn't work when the query uses an alias:

User::from('users as alias')->update(['foo' => 'bar']);

update `users` as `alias` set `foo` = bar, `users`.`updated_at` = 2019-05-24 20:12:50
                                            ^^^^^

Fixes #28569.

@taylorotwell taylorotwell merged commit 9c21900 into laravel:5.8 May 25, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@staudenmeir staudenmeir deleted the staudenmeir:update-alias branch May 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.