Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Parse Url in Redis configuration #28612

Merged
merged 5 commits into from May 27, 2019

Conversation

Projects
None yet
5 participants
@mathieutu
Copy link
Contributor

commented May 25, 2019

As it was done for url databases in #28308 and much requested on Twitter and in previouses PR, this one allows usage of an url key in Redis configuration.

mathieutu added some commits May 25, 2019

@robinvdvleuten

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

It would be nice if the path can be used to configure the database (redis://localhost:6379/1) as well. Maybe something like substr('<path..>', '/0'), 1)?

@mathieutu

This comment has been minimized.

Copy link
Contributor Author

commented May 27, 2019

Actually, it's already the case @robinvdvleuten 😉.

I let you see the previous PR to understand what the ConfigurationUrlParser does.

@robinvdvleuten

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

@taylorotwell taylorotwell merged commit a8fc3a8 into laravel:5.8 May 27, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mathieutu

This comment has been minimized.

Copy link
Contributor Author

commented May 27, 2019

We could decide to wing it and just move the class in the current release. Think that the best option for now but unfortunately it'll be a breaking change. Otherwise the only thing we can do is do the changes in the next release.

Apparently, Taylor made his choice ¯_(ツ)_/¯

taylorotwell added a commit to laravel/laravel that referenced this pull request May 30, 2019

realodix added a commit to realodix/urlhub that referenced this pull request May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.