Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Allow rescued exception reporting to be disabled #28617

Merged
merged 1 commit into from May 26, 2019

Conversation

Projects
None yet
2 participants
@robinvdvleuten
Copy link
Contributor

commented May 26, 2019

The rescue helper is definitely one of my favorites and use it a lot for parsing of request query values like dates for example. It's just quite annoying that the exceptions get reported even if I don't care about them at that specific location in my application logic.

I know that I can ignore the exception class in the handler, but sometimes the thrown exception still makes sense at other places.

This PR adds an optional boolean to the helper to allow exceptions to be just ignored instead of reporting them by default.

@taylorotwell taylorotwell merged commit 4cff1ee into laravel:5.8 May 26, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.