[5.8] Allow setting additional smtp config options - #28631
Merged
Merged
Conversation
Allow setting additional smtp config options
GrahamCampbell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
laravel/ideas#1661
Allows configuring the source IP address used by swift mailer. Useful on servers with multiple ip addresses, or servers with both IPv4 and IPv6 addresses.
Allows configuring the localdomain sent by the swift mailer in the HELO or EHLO command. The default behavior is to send the server's name, but for sub-domain servers, it would be better to send the root domain (example.com instead of www.example.com).
Neither of these would change existing behavior unless config values were set.
I couldn't find any existing tests around transport manager to base my tests around, and wasn't sure how to test the purpose of this.