Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Allow setting additional smtp config options #28631

Merged
merged 2 commits into from May 27, 2019

Conversation

Projects
None yet
2 participants
@JustinBerger
Copy link
Contributor

commented May 27, 2019

laravel/ideas#1661
Allows configuring the source IP address used by swift mailer. Useful on servers with multiple ip addresses, or servers with both IPv4 and IPv6 addresses.

Allows configuring the localdomain sent by the swift mailer in the HELO or EHLO command. The default behavior is to send the server's name, but for sub-domain servers, it would be better to send the root domain (example.com instead of www.example.com).

Neither of these would change existing behavior unless config values were set.

I couldn't find any existing tests around transport manager to base my tests around, and wasn't sure how to test the purpose of this.

JustinBerger added some commits May 27, 2019

Merge pull request #1 from JustinBerger/jb-smtp-options
Allow setting additional smtp config options

@taylorotwell taylorotwell merged commit 7ed1dad into laravel:5.8 May 27, 2019

1 of 2 checks passed

continuous-integration/styleci/pr Issues have been identified with 1 file
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GrahamCampbell GrahamCampbell changed the title Allow setting additional smtp config options [5.8] Allow setting additional smtp config options May 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.