Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.9] Drop Carbon v1 #28683

Merged
merged 1 commit into from May 31, 2019

Conversation

@driesvints
Copy link
Member

commented May 31, 2019

Carbon v1 is now warning to drop support and upgrade to v2 instead so it's best that we drop support for it in newer versions. See briannesbitt/Carbon#1685

Drop Carbon v1
Carbon v1 is now warning to drop support and upgrade to v2 instead so it's best that we drop support for it in newer versions. See briannesbitt/Carbon#1685

@driesvints driesvints force-pushed the driesvints:drop-carbon-1-support branch from e855140 to ccae6f4 May 31, 2019

@taylorotwell taylorotwell merged commit d9ffff2 into laravel:master May 31, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/styleci/pr The analysis has passed
Details

@driesvints driesvints deleted the driesvints:drop-carbon-1-support branch May 31, 2019

@bobdenotter

This comment has been minimized.

Copy link

commented on ccae6f4 Jun 1, 2019

Note that if you do this, you'll need to raise the global requirement for PHP in composer.json too, because Carbon 2 requires PHP 7.1.8

https://github.com/laravel/framework/blob/5.8/composer.json#L18 <- PHP 7.1.3

@kylekatarnls

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

Thanks @driesvints it will help me to focus maintenance efforts on Carbon 2.

@bobdenotter It's for 5.9, not 5.8. But indeed, the minimum PHP version becomes 7.1.8 de facto and should be reflected in the composer.json and doc.

For the record, we need 7.1.8 because of this bug fixed in this version:

Fixed bug #74852 (property_exists returns true on unknown DateInterval property).
https://bugs.php.net/bug.php?id=74852

@kylekatarnls

This comment has been minimized.

Copy link
Contributor

commented Jun 1, 2019

I will check if we can work around this bug and support 7.1.3.

@driesvints

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2019

@bobdenotter @kylekatarnls the next Laravel version has a minimum requirement of PHP 7.2 so we should be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.