Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Error handling for maintenance mode commands #28765

Merged
merged 2 commits into from Jun 8, 2019

Conversation

Projects
None yet
2 participants
@match
Copy link

commented Jun 8, 2019

Artisan command for controlling maintenance mode has not handled errors.

When execute commands by non-granted user,
artisan down throw Exception error messages, and also
artisan up shows Application is now live. but still maintenance mode.

This PR implements error handlings for that.

Command behavior is belows:

  • artisan down

    • success: Display Application is now in maintenance mode. with exit_status = 0
    • failed: Display Application is failed to enter maintenance mode. with exit_status = 1
  • artisan up

    • success to up: Display Application is now live. with exit_status = 0
    • already up: Display Application is already up. with exit_status = 0
    • failed: Display Application is failed to up. with exit_status = 1

Yohei Matsuhashi added some commits Jun 8, 2019

@match match force-pushed the match:error-handling-for-maintenance-mode branch from 802314c to 6082be0 Jun 8, 2019

@taylorotwell taylorotwell merged commit 6082be0 into laravel:5.8 Jun 8, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@match match deleted the match:error-handling-for-maintenance-mode branch Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.