[5.8] Fix strict comparison in redis configuration Parsing#28830
Merged
Conversation
Member
|
@mathieutu I still feel we should add tests for this, otherwise we risk that this breaks again in a future update. Maybe we should leave this open for a bit until someone can PR in a test to your PR? |
Contributor
Author
|
@driesvints Actually this particular PR fixes a bug people have, so we have to merge it as soon as possible, and this is on a very specific part that will not cause any breaking change (just adding strictness on internal check). |
Contributor
|
@driesvints We can't update Laravel on this moment anymore, this bug are highprio for us. With this fix we are can update Laravel to te newest version. |
Contributor
|
@mathieutu created an issue for the tests #28852 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proper fix for issue #28829.
Problem:
Input of the function:
[0 => 'url1', 1 => 'url2', 2 => 'url3']Expected output:
[0 => 'url1', 1 => 'url2', 2 => 'url3']Actual output:
[1 => 'url2', 2 => 'url3']This is about strict comparison in
in_arraymethod:Thanks.
Matt'
PS: Again, this would not happen with tests.
I have no time to add proper tests on all of this RedisManager, but I think this is something we should have. Can be a good first PR for someone who want to contribute.