[5.8] Allow console environment argument to be separated with a space#28869
Merged
taylorotwell merged 1 commit intolaravel:5.8from Jun 17, 2019
ThibaudDauce:console-environment-separated-with-space
Merged
[5.8] Allow console environment argument to be separated with a space#28869taylorotwell merged 1 commit intolaravel:5.8from ThibaudDauce:console-environment-separated-with-space
taylorotwell merged 1 commit intolaravel:5.8from
ThibaudDauce:console-environment-separated-with-space
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following explanations are from @matt-allan in the issue #28831:
The Symfony console component that is used by the Artisan console allows separating option names and values with either a space or an equals (=) sign. For example:
However, the
--envoption is only parsed correctly if you use an equals sign. If you use a spaceapp()->environment()will return false.This inconsistency is pretty confusing and difficult to debug. If you dump
$this->option('env')in a command it will return the expected value butapp()->environment()will return false.Fixes #28831