Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] compile `@endcomponentFirst` #28884

Merged
merged 1 commit into from Jun 19, 2019

Conversation

Projects
None yet
2 participants
@browner12
Copy link
Contributor

commented Jun 18, 2019

while the @endcomponent directive is perfectly valid to end a @componentFirst, the IDEs struggle to match the 2 up resulting in a syntax error, which I'm sure people will be upset about.

I would prefer the plugin handle this if it can, but I'm not sure if it can, or where to change that, so I'm PR'ing here for now.

compile `@endcomponentFirst`
while the `@endcomponent` directive is perfectly valid to end a `@componentFirst`, the IDEs struggle to match the 2 up resulting in a syntax error, which I'm sure people will be upset about.

I would prefer the plugin handle this if it can, but I'm not sure if it can, or where to change that, so I'm PR'ing here for now.

@taylorotwell taylorotwell merged commit 024783a into laravel:5.8 Jun 19, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@browner12 browner12 deleted the browner12:endComponentFirst branch Jun 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.