[5.8] Prevent event cache from firing multiple times the same event(s)#28904
Merged
taylorotwell merged 1 commit intolaravel:5.8from Jun 21, 2019
jf-m:fix/28872
Merged
[5.8] Prevent event cache from firing multiple times the same event(s)#28904taylorotwell merged 1 commit intolaravel:5.8from jf-m:fix/28872
taylorotwell merged 1 commit intolaravel:5.8from
jf-m:fix/28872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed solution for solving #28872 .
Changes explanations:
EventCacheCommand
discoverEventsare cached only whenshouldDiscoverEventsis true on the related providers, otherwise only thelistensare cached.events.phpso the the events/Listeners are grouped by EventServiceProvider.instead of the old structure :
array_mergetoarray_merge_recursivebecause it still is technically possible that a basiclistenevent is also inside a discovered event.EventServiceProvider
bootmethods now calls agetEventsto get the events of both discover and listengetEventswill return ONLY the events located under the name of the current EventServiceProvider in theevents.phpcache.Indeed, the $this->listens() are already cached and they are all located inside the cache file, so there is no need to merge the cache file with listens;
There is also no need to check for
shouldDiscoverEventsbecause it was already done inside theevent:cachecommand.I hope this helps, cheers !