Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix for ascii equivalent for greek letter theta #28999

Merged
merged 1 commit into from Jun 30, 2019

Conversation

Projects
None yet
2 participants
@nikosv
Copy link
Contributor

commented Jun 30, 2019

This is a fix for the Greek letter Theta (https://en.wikipedia.org/wiki/Theta) which is now replaced by O which is completely irrelevant.
I believe this was a mistake in the original code due to the cyrilic ө (https://en.wiktionary.org/wiki/%D3%A8) which is correctly replaced by ο (it is left untouched in my proposal).

This fix can probably be applied all the way back to 5.5 version.

I have also created a PR to the original source danielstjules/Stringy#193 but the project seems abandonded. However my changes were copied on a better mantained fork https://github.com/voku/Stringy

P.S. I am a Greek native speaker

Fix for ascii equivalent for greek letter theta
This is a fix for the Greek letter Theta (https://en.wikipedia.org/wiki/Theta) which is now replaced by O which is completely irrelevant.
I believe this was a mistake in the original code due to the cyrilic ө (https://en.wiktionary.org/wiki/%D3%A8) which is correctly replaced by ο (it is left untouched in my proposal).

I have also created a PR to the original source danielstjules/Stringy#193 but the project seems abandonded. However my changes were copied on a better mantained fork https://github.com/voku/Stringy

P.S. I am a Greek native speaker

@GrahamCampbell GrahamCampbell changed the title Fix for ascii equivalent for greek letter theta [5.8] Fix for ascii equivalent for greek letter theta Jun 30, 2019

@taylorotwell taylorotwell merged commit d1512ee into laravel:5.8 Jun 30, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.