Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fixes Issue #28984, defer in app.js script prevents jquery components from loading. #29001

Merged
merged 1 commit into from Jun 30, 2019

Conversation

Projects
None yet
6 participants
@mikestratton
Copy link
Contributor

commented Jun 30, 2019

Defer in javascript prevents jqueryui components from loading.

Fixes Issue #28984
Defer in javascript prevents jqueryui components from loading.

@GrahamCampbell GrahamCampbell changed the title Fixes Issue #28984, defer in app.js script prevents jquery components from loading. [5.8] Fixes Issue #28984, defer in app.js script prevents jquery components from loading. Jun 30, 2019

@taylorotwell taylorotwell merged commit 1f3cbcf into laravel:5.8 Jun 30, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@devcircus

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2019

So we're now loading javascript in the head without defer? In order to handle the use of jquery-ui? This file is provided to get you started. It's yours to edit as you need it. It should handle the majority use-case and if you have an edge-case, change it. Jquery-ui is an edge case. But 🤷🏻‍♂️

@GrahamCampbell

This comment has been minimized.

Copy link
Member

commented Jun 30, 2019

Yeh, this is kinda odd. Ping @taylorotwell.

@devcircus

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2019

Just move it back to the bottom I guess? Seems strange for it to cause issues with jquery-ui. Haven't used it in years though.

@dongido001

This comment has been minimized.

Copy link

commented Jul 8, 2019

@driesvints

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

I've reverted this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.