Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fixed cache repository setMultiple with an iterator #29039

Merged
merged 1 commit into from Jul 3, 2019

Conversation

Projects
None yet
2 participants
@GrahamCampbell
Copy link
Member

commented Jul 2, 2019

The Psr\SimpleCache\CacheInterface interface we implement says that an arbitrary iterable can be passed to setMultiple, thus we need to convert it to an array before we pass it to putMany.


Without this fix, the following error will occur it something iterable that's not an array is used:

TypeError: Argument 1 passed to Illuminate\Cache\Repository::putMany() must be of the type array, object given, called in /data/src/Illuminate/Cache/Repository.php on line 232

/data/src/Illuminate/Cache/Repository.php:216
/data/src/Illuminate/Cache/Repository.php:232

@taylorotwell taylorotwell merged commit b038bdc into 5.8 Jul 3, 2019

4 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@driesvints driesvints deleted the 5.8-cache-set-multiple branch Jul 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.