[5.8] Add replace() and replaceRecursive() methods on collections#29088
Merged
taylorotwell merged 2 commits intolaravel:5.8from Jul 6, 2019
iamgergo:5.8
Merged
[5.8] Add replace() and replaceRecursive() methods on collections#29088taylorotwell merged 2 commits intolaravel:5.8from iamgergo:5.8
taylorotwell merged 2 commits intolaravel:5.8from
iamgergo:5.8
Conversation
Contributor
|
Resubmit of #20220. |
Contributor
Author
|
Yes, the functionality is the same, but this PR contains more tests for both functions. Also, there is a suggestion to use The other problem with Maybe using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the PHP
array_replaceand thearray_replace_recursivebehavior on the collections.With associative array keys,
array_mergeandarray_replacebehave the same way. However, with numeric keys/indexes, the merge appends the values to the array, but replace overrides the original value of the specific indexes.