Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] WithFaker use local faker config #29123

Merged
merged 1 commit into from Jul 10, 2019

Conversation

@cxlblm
Copy link
Contributor

commented Jul 10, 2019

WithFaker use local faker config

WithFaker use local faker config
WithFaker use local faker config

@GrahamCampbell GrahamCampbell changed the title WithFaker use local faker config [5.8] WithFaker use local faker config Jul 10, 2019

@taylorotwell taylorotwell merged commit fccb701 into laravel:5.8 Jul 10, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@GrahamCampbell

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

This was actually already added to Laravel 5.9 in #28478, because it was a breaking change. I think we should revert this PR to 5.8.

devcircus referenced this pull request Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.