Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fixed validator not failing on custom rule when message is null #29174

Merged
merged 1 commit into from Jul 15, 2019

Conversation

@stevebauman
Copy link
Contributor

commented Jul 15, 2019

Issue: #29171

@stevebauman stevebauman changed the title Fixed validator not failing on custom rule when message is null [5.8] Fixed validator not failing on custom rule when message is null Jul 15, 2019

@taylorotwell taylorotwell merged commit ec6bf0a into laravel:5.8 Jul 15, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@StefanPrintezis

This comment has been minimized.

Copy link

commented Jul 15, 2019

We can also prevent messages from ever returning null since that’s not allowed to prevent any other issues. Might be a cleaner approach.

The return type of message() can be :string since 5.8 requires at least php 7.1.3.
Changing the return type will break backwards compatibility tho. So maybe next minor version?

@chriskonnertz

This comment has been minimized.

Copy link

commented Jul 16, 2019

Larvel does not use type hints for return values at the moment.

@stevebauman stevebauman deleted the stevebauman:patch-2 branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.