Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix conditional binding for nested optional dependencies #29180

Conversation

@Organizm238
Copy link
Contributor

commented Jul 16, 2019

This should fix #29019

Seems like we were not popping last class from buildStack in case dependency was not resolved, which, In case we have optional dependency, lead to bug.

Organizm238 added some commits Jul 15, 2019

@Organizm238 Organizm238 changed the title Fix conditional binding for nested optional dependencies [5.8] Fix conditional binding for nested optional dependencies Jul 16, 2019

Organizm238 and others added some commits Jul 16, 2019

@taylorotwell taylorotwell merged commit 2177364 into laravel:5.8 Jul 16, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/styleci/pr The analysis has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.