Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Revert "[5.8] WithFaker use local faker config" #29250

Merged
merged 1 commit into from Jul 21, 2019

Conversation

@GrahamCampbell
Copy link
Member

commented Jul 21, 2019

Reverts #29123 because it already exists on master due to an earlier PR, and was targetting 5.9 instead of 5.8 because it was a breaking change.

@taylorotwell taylorotwell merged commit 06c4b75 into 5.8 Jul 21, 2019

4 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@GrahamCampbell GrahamCampbell deleted the revert-29123-5.8 branch Jul 21, 2019

@stephanecoinon

This comment has been minimized.

Copy link

commented on f1a7255 Jul 28, 2019

Hey @GrahamCampbell , why revert this PR? This would be very handy outside the US

This comment has been minimized.

Copy link
Contributor

replied Jul 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.