[5.8] Teardown test suite after using fail() method

[themsaid]

This PR has 2 changes:

1. Ensures all beforeApplicationDestroyedCallbacks are called by catching any exceptions thrown during one of the callbacks.
2. It removes the once() method so mockery doesn't run verifications on the count, this will allow our mechanism to handle failure using $this->fail();

[paulhenri-l]

Well this seems ok to me :)

[paulhenri-l]

I had not seen your new changes with the addition of the callbackException property.

Well I guess this will work since we are no longer preventing other callbacks from running.

Well done :)

[paulhenri-l]

Changes will still need to be replicated in orchestral/testbench-core#25 though.

Do you want me to do it or will you?

[taylorotwell]

What problem is this solving? Thanks!

[paulhenri-l]

@taylorotwell This one #29246

Steps to reproduce can be found at the bottom of the issue (#29246 (comment))

This bug is kind of hard to explain but I'll do my best :)

Currently if you use expectsOutput in a test and the expectation fails the test suite cannot properly tear down.

That is because InteractsWithConsole calls $this->fail() in its afterApplicationDestroyed callback. Under the hood $this->fails() throws an exception.

This exception breaks the flow of execution of the tearDown() method preventing subsequent afterApplicationDestroyed callbacks from being called as-well as the rest of the tearDown() method.

    /**
     * Clean up the testing environment before the next test.
     *
     * @return void
     */
    protected function tearDown(): void
    {
        if ($this->app) {
            foreach ($this->beforeApplicationDestroyedCallbacks as $callback) {
                call_user_func($callback); // <------- The exception is thrown here.
                // Everything below this line is thus never executed
            }

            $this->app->flush();
            $this->app = null;
        }
        
       // ... Code here won't get executed as-well
    }

I can give more details about the bug if you want but I think this will give you enough informations.