[5.8] Fix UPDATE and DELETE queries with join bindings on PostgreSQL

[staudenmeir]

On PostgreSQL, Laravel implements UPDATE and DELETE queries with joins by adding their constraints after the WHERE constraints. If both clauses have bindings, their order is incorrect:

DB::table('comments')
    ->join('posts', function ($join) {
        $join->on('posts.id', '=', 'comments.commentable_id')
            ->where('comments.commentable_type', 'App\Post');
    })
    ->where('posts.active', 0)
    ->delete();

delete from "comments" USING "posts"
where "posts"."active" = 'App\Post'
  and "posts"."id" = "comments"."commentable_id"
  and "comments"."commentable_type" = 0

We have to put the where bindings before the join bindings.

We could also swap the constraints in the generated SQL, but that's quite cumbersome.

[derekmd]

#18694 Related issue?

[staudenmeir]

@derekmd Both issues are related to PostgreSQL's syntax for UPDATE and DELETE queries, but they aren't directly related to each other. I'm also working on a solution for #18694.

[driesvints]

@staudenmeir thanks for all your help lately with these database issues! 👏