Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix worker timeout handler when there is no job processing #29366

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@djtarazona
Copy link
Contributor

commented Aug 1, 2019

Fixes the issue mentioned in #29024 (comment)

The queue worker timeout handler may be called with a null $job if the timeout is reached when there is no job processing (perhaps it took too long to fetch the next job in the worker loop). This fix checks to make sure there is a job before attempting to mark the as failed if it will exceed the maximum number of attempts.

Fix worker timeout handler for null `$job`
The queue worker timeout handler may be called with a null `$job` if the
timeout is reached when there is no job processing (perhaps it took too long
to fetch the next job in the worker loop). This fix checks to make sure there
is a job before attempting to mark the as failed if it will exceed the maximum
number of attempts.
@djtarazona

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

@cannahan Can you see if this fixes your issue? #29024 (comment)

@taylorotwell taylorotwell merged commit c7eaba6 into laravel:5.8 Aug 1, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@GrahamCampbell GrahamCampbell changed the title Fix worker timeout handler when there is no job processing [5.8] Fix worker timeout handler when there is no job processing Aug 1, 2019

@cannahan

This comment has been minimized.

Copy link

commented Aug 1, 2019

@djtarazona Thanks for taking the time. It works. Much appreciated

@djtarazona djtarazona deleted the djtarazona:patch-1 branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.