[5.8] Fix worker timeout handler when there is no job processing#29366
Merged
Conversation
The queue worker timeout handler may be called with a null `$job` if the timeout is reached when there is no job processing (perhaps it took too long to fetch the next job in the worker loop). This fix checks to make sure there is a job before attempting to mark the as failed if it will exceed the maximum number of attempts.
Contributor
Author
|
@cannahan Can you see if this fixes your issue? #29024 (comment) |
GrahamCampbell
changed the title
|
@djtarazona Thanks for taking the time. It works. Much appreciated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue mentioned in #29024 (comment)
The queue worker timeout handler may be called with a null
$jobif the timeout is reached when there is no job processing (perhaps it took too long to fetch the next job in the worker loop). This fix checks to make sure there is a job before attempting to mark the as failed if it will exceed the maximum number of attempts.