Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix assertJsonValidationErrors with muliple messages #29380

Merged
merged 4 commits into from Aug 2, 2019

Conversation

@MoonHyuk
Copy link
Contributor

commented Aug 2, 2019

assertJsonValidationErrors only tests first message of given array.

for example,

$this->assertJsonValidationErrors([
    'body' => 'required',
    'receiver' => 'required'
]);

This test seems to work well, but the test below passes too.

$this->assertJsonValidationErrors([
    'body' => 'required',
    'receiver' => 'requiredddddd'
]);

And it's wierd because there is no error message like 'requiredddddd'

Apply suggestions from code review
Co-Authored-By: Dries Vints <dries.vints@gmail.com>

Changes made

@taylorotwell taylorotwell merged commit 4d3f770 into laravel:5.8 Aug 2, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.