Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Procedural date creation returned false #29389

Conversation

@LarsGrevelink
Copy link
Contributor

commented Aug 2, 2019

date_create returns false instead of null on failure. To keep everything as intended we convert it no null when it fails. There are no other expected falsy results coming from this function on the successful execution of it.

Related to pull request #29342.

Have a great weekend!

@taylorotwell taylorotwell merged commit a78203a into laravel:5.8 Aug 2, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.