[5.8] Array cache forget should return false on missing key#29427
Merged
taylorotwell merged 1 commit intolaravel:5.8from Aug 6, 2019
stevelacey:patch-1
Merged
[5.8] Array cache forget should return false on missing key#29427taylorotwell merged 1 commit intolaravel:5.8from stevelacey:patch-1
taylorotwell merged 1 commit intolaravel:5.8from
stevelacey:patch-1
Conversation
Contributor
Author
|
Note, I used
|
driesvints
approved these changes
Aug 6, 2019
danilopinotti
approved these changes
Aug 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
arraycache driver currently returnstruefor allforget()calls. I think it should returnfalseif there was no matching key, to better match the other drivers likememcachedandredis.I based this PR to 5.8 given anyone checking the return value of forget is probably expecting this behaviour? Not sure if this is BC incompatible enough to warrant pushing it to 6.0.
I am using the return value of
forgetto show whether a nonce is valid, so was expecting atrue(and for the nonce to then be removed), and subsequentfalse's which works fine via theredisandmemcacheddrivers, but not in the tests which usearray.