Skip to content

[5.8] Allow chaining on Query Builder dump() method#29437

Merged
taylorotwell merged 2 commits into
laravel:5.8from
alexbowers:patch-1
Aug 6, 2019
Merged

[5.8] Allow chaining on Query Builder dump() method#29437
taylorotwell merged 2 commits into
laravel:5.8from
alexbowers:patch-1

Conversation

@alexbowers
Copy link
Copy Markdown
Contributor

This fixes a mistake in my previous PR to add this.

It currently isn't possible to chain onto the dump method.

@driesvints driesvints changed the title Update Builder.php [5.8] Update Builder.php Aug 6, 2019
@alexbowers alexbowers changed the title [5.8] Update Builder.php [5.8] Allow chaining on Query Builder dump() method. Aug 6, 2019
@taylorotwell taylorotwell merged commit 41cfdbd into laravel:5.8 Aug 6, 2019
@brunogaspar
Copy link
Copy Markdown
Member

You just forgot to update the docblock heh

@driesvints
Copy link
Copy Markdown
Member

@brunogaspar fixed.

@GrahamCampbell GrahamCampbell changed the title [5.8] Allow chaining on Query Builder dump() method. [5.8] Allow chaining on Query Builder dump() method Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants