[5.8] Only remove the event mutex if it was created #29526
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to fix an issue that throws PHP Fatal errors when running the scheduler in a test.
Description of the issue
CallbackEvent
with a description (i.e. using thename()
method)$this->artisan('schedule:run')
Note that, since
$schedule->job()
is syntactic sugar for$schedule->call()->name()
, the same issue occurs when scheduling a job. Please see issue #29394 for more information including the steps to reproduce on a fresh Laravel install.The origin of the problem
The PHP Fatal errors are thrown when removing the mutex of a
CallbackEvent
. (see source)As you can see we only remove the mutex if a description was provided. However, since we are not using the
withoutOverlapping
option, that mutex was never created in the first place. (see source)The solution
Making sure that the conditions of creating and removing an event mutex are identical fixes our issue.
Fix #29394