[5.8] Add ValidatesWhenResolvedTrait::passedValidation() callback#29549
Merged
Conversation
tillkruss
changed the title
Contributor
|
It's not obvious if I would suggest keeping the same convention as |
Contributor
Author
|
Great suggestion! |
tillkruss
changed the title
Contributor
|
glad this is merged 😄 . i tried it once in this PR but didn't have luck 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the
prepareForValidation()callback, it would be quite handy to have aafterValidation()callback as well.This would allow us to apply filters to request values, such as converting types without interfering with Laravel validation.