[5.8] Fix non-displayable boolean values in validation messages #29560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coquer
reviewed
Aug 14, 2019
| @@ -320,6 +320,10 @@ public function getDisplayableValue($attribute, $value) | |||
| return $line; | |||
| } | |||
|
|
|||
| if (is_bool($value)) { | |||
| return $value ? 'true' : 'false'; | |||
There was a problem hiding this comment.
good point. I'm not sure if it should be translated as it's a reference to the data type
There was a problem hiding this comment.
@taylorotwell would you accept a PR that makes this strings translatable?
GrahamCampbell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boolean values are not represented as strings in validation messages, this PR fixes that.