Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix exception message #29568

Merged
merged 1 commit into from Aug 14, 2019

Conversation

@xuanquynh
Copy link
Contributor

commented Aug 14, 2019

The manifestPath property is a dependency of ProviderRepository and was provided by Application::getCachedServicesPath(). It can be changed.

The current message exception is fixed and will be wrong if a developer changes his/her bootstrap/cace directory.

I also add a test for the case in which the directory doesn't exist.

@taylorotwell taylorotwell merged commit 43e7387 into laravel:5.8 Aug 14, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@xuanquynh xuanquynh deleted the xuanquynh:fix_exception_message branch Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.