Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Fix command output/questions expectations #29580

Merged
merged 3 commits into from Aug 15, 2019

Conversation

@themsaid
Copy link
Member

commented Aug 15, 2019

As reported in #29521, when trying to test that a question was asked multiple times or output was printed multiple times, the out of order exception is thrown.

This PR brings back the use of once(). However, it handles the Mockery exception thrown so instead of people seeing:

Mockery\Exception\InvalidCountException: Method doWrite('hola mundo', <Any>) from Mockery_0_Symfony_Component_Console_Output_BufferedOutput should be called
 exactly 1 times but called 0 times.

People see:

Output "hola mundo" was not printed.
themsaid added 2 commits Aug 13, 2019

@themsaid themsaid requested a review from driesvints Aug 15, 2019

@taylorotwell taylorotwell merged commit 8714896 into laravel:5.8 Aug 15, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.