Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Ignore classes which are not instantiable during event discovery #29587

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@wgriffioen
Copy link
Contributor

commented Aug 15, 2019

If you enable auto discovery of events and listeners, the framework tries to attach abstract classes and interfaces to the events, which triggers a BindingResolutionException with the following message:

Target [App\Listeners\AbstractListener] is not instantiable

With this pull request, an extra check is performed to make sure the listener is instantiable. This prevents a BindingResolutionException.

@taylorotwell taylorotwell merged commit ff9ff02 into laravel:5.8 Aug 15, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.