[5.8] Use real classname for seeders#29601
Merged
taylorotwell merged 1 commit intolaravel:5.8from Aug 16, 2019
jerguslejko:patch-1
Merged
[5.8] Use real classname for seeders#29601taylorotwell merged 1 commit intolaravel:5.8from jerguslejko:patch-1
taylorotwell merged 1 commit intolaravel:5.8from
jerguslejko:patch-1
Conversation
This way, if a programmer decides to override (example below) a seeder in a container, an actual class name is printed instead of the parent class name.
Example:
I'm working on a multi-tenant app, where each tenant has its own "configuration" folder (contains a service provider and some additional classes such as seeders for example). I can choose which configuration is enabled by tweaking an environment variable.
```php
class PostsSeeder {}
class TenantAPostsSeeder extends PostsSeeder {}
```
With this change, I'll be able to tell which seeder is actually being executed when I run `php artisan db:seed`
Contributor
|
@jerguslejko Thank you for that feature! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, if a programmer decides to override (example below) a seeder in a container, an actual class name is printed instead of the parent class name.
Example:
I'm working on a multi-tenant app, where each tenant has its own "configuration" folder (contains a service provider and some additional classes such as seeders for example). I can choose which configuration is enabled by tweaking an environment variable.
With this change, I'll be able to tell which seeder is actually being executed when I run
php artisan db:seed