[5.8] Bugfix - QueueFake size method and added a test

[hlorofos]

This is fixing #29755

[GrahamCampbell]

This will break if the queue is null?

[hlorofos]

This will break if the queue is null?

@GrahamCampbell thats why I put first assertion in the test without pushing anything to a queue:

Queue::fake();
        $this->assertEquals(0, Queue::size());

there is initializer for $job in QueueFake

    protected $jobs = [];

[GrahamCampbell]

No, I mean if there are jobs, but the queue name is null, it should be non-zero.

[GrahamCampbell]

To clarify, in Laravel, using null for the queue name means "use the default". This needs to be handled within the implementation.

[hlorofos]

To clarify, in Laravel, using null for the queue name means "use the default". This needs to be handled within the implementation.

@GrahamCampbell , here are my explanations in the test, please consider if possible to explain what's wrong based on the test:

        dispatch($job); // Pushed to default queue
        dispatch(new TestJob2); //  Other job pushed to default queue, this would validate we traverse through different job classes properly
        dispatch($job)->onQueue('Q2'); // Pushed to queue 'Q2'

        $this->assertEquals(2, Queue::size()); // Get the amount of jobs in default queue, internally its NULL for QueueFake
        $this->assertEquals(1, Queue::size('Q2')); // Get the amount of jobs in queue `Q2`

If you're talking about default property for Queue implementations this have nothing to do with QueueFake implementation.

[taylorotwell]

I think you can already assert on Queue::pushedJobs() when using the fake. I'm not sure having size always return the number of pushed jobs makes sense.

[hlorofos]

@taylorotwell you interpret this wrong, I'm testing my code which expose Queue::size through API. Since I'm faking queue and testing API which calling size() - as a developer I expect size method return proper value instead of some random number.

[driesvints]

@hlorofos we got this merged 👍

[hlorofos]

@hlorofos we got this merged 👍

@driesvints appreciate all your help along the way!