Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Add hebrew letters to Str:slug language array #29838

Merged
merged 3 commits into from Sep 3, 2019

Conversation

@GabMic
Copy link
Contributor

commented Sep 3, 2019

This will add a Hebrew support to the Str::slug() helper.

@GrahamCampbell GrahamCampbell changed the title Add hebrew letters to Str:slug language array [5.8] Add hebrew letters to Str:slug language array Sep 3, 2019

@GrahamCampbell

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Thanks for the PR. I think we'd probably accept this if it is accepted at https://github.com/danielstjules/Stringy.

@GabMic

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

Thanks for the PR. I think we'd probably accept this if it is accepted at https://github.com/danielstjules/Stringy.

That will be great.

@taylorotwell taylorotwell merged commit 5147367 into laravel:5.8 Sep 3, 2019

0 of 2 checks passed

continuous-integration/styleci/pr Issues have been identified with 1 file
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.