Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Backport PHP 7.4 Support #29842

Merged
merged 1 commit into from
Sep 3, 2019
Merged

[5.8] Backport PHP 7.4 Support #29842

merged 1 commit into from
Sep 3, 2019

Conversation

GrahamCampbell
Copy link
Member

No description provided.

@GrahamCampbell
Copy link
Member Author

Hmm, well Symfony 4.2 just isn't ever going to be patched for PHP 7.4 I don't think...

@driesvints
Copy link
Member

I don't think we should touch the versions for 5.8 and that we should only test 7.4snapshot on the latest releases, not the lowest ones.

@GrahamCampbell
Copy link
Member Author

Yeh, I agree.

@GrahamCampbell
Copy link
Member Author

Right. Give me a minute. :P

Co-authored-by: Dries Vints <dries.vints@gmail.com>
@taylorotwell taylorotwell merged commit dbb3b8c into 5.8 Sep 3, 2019
@GrahamCampbell GrahamCampbell deleted the 5.8-php-7.4 branch September 3, 2019 16:37
jmsfwk added a commit to iamproperty/framework that referenced this pull request Feb 28, 2022
Co-authored-by: Dries Vints <dries.vints@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants