Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Backport PHP 7.4 Support #29842

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@GrahamCampbell
Copy link
Member

commented Sep 3, 2019

No description provided.

@GrahamCampbell GrahamCampbell requested a review from driesvints Sep 3, 2019

@GrahamCampbell

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

Hmm, well Symfony 4.2 just isn't ever going to be patched for PHP 7.4 I don't think...

@driesvints

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

I don't think we should touch the versions for 5.8 and that we should only test 7.4snapshot on the latest releases, not the lowest ones.

@GrahamCampbell

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

Yeh, I agree.

@GrahamCampbell

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

Right. Give me a minute. :P

Backport PHP 7.4 Support
Co-authored-by: Dries Vints <dries.vints@gmail.com>

@GrahamCampbell GrahamCampbell force-pushed the 5.8-php-7.4 branch from a95bd8c to 0ba1d71 Sep 3, 2019

@taylorotwell taylorotwell merged commit dbb3b8c into 5.8 Sep 3, 2019

4 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@GrahamCampbell GrahamCampbell deleted the 5.8-php-7.4 branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.