Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Sort missed stub imports #29958

Merged
merged 1 commit into from Sep 11, 2019

Conversation

@netpok
Copy link
Contributor

commented Sep 11, 2019

Previous pull request #29954 missed some import, this pull request fixes those.

This is a cosmetic change that does not affect the output in any way as it will be sorted after stub compiling.

This pull request was generated with the same code used after compiling and run on every *.stub so there shouldn't be any missed stub.

@taylorotwell taylorotwell merged commit e879699 into laravel:6.x Sep 11, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@netpok netpok deleted the netpok:feature/sort-imports branch Sep 11, 2019
@antonkomarev

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

They were in this state because without your PR #29951 they all will have App name by default and were meant to be on the first place to be in right order. But your addition of import sorter let us to keep style consistency even in stub files. 💟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.