Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Better readability in auth.throttle translation #30011

Merged
merged 2 commits into from Sep 17, 2019

Conversation

@redelschaap
Copy link
Contributor

redelschaap commented Sep 17, 2019

When actively implementing authentication throttling, we noticed that end users now get messages like "please try again in 878 seconds" when we configured the throttle to be 15 minutes. This is not very user friendly.

With this adjustment, we make minutes available in the in auth.throttle translation message for better readability.

redelschaap added 2 commits Sep 17, 2019
In auth.throttle translation, make minutes available in message for better readability.
@GrahamCampbell GrahamCampbell changed the title Better readability in auth.throttle translation [6.x] Better readability in auth.throttle translation Sep 17, 2019
@taylorotwell taylorotwell merged commit 741c4de into laravel:6.x Sep 17, 2019
2 checks passed
2 checks passed
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sertxudeveloper

This comment has been minimized.

Copy link

sertxudeveloper commented Oct 1, 2019

But with this pull request, what happens with the translation inside the default lang auth file?
https://github.com/laravel/laravel/blob/master/resources/lang/en/auth.php

@redelschaap

This comment has been minimized.

Copy link
Contributor Author

redelschaap commented Oct 1, 2019

Nothing, because by default the time out on authorization is 1 minute. So by default you want to use the seconds. But if you set the time out to let's say 10 minutes, it's more user friendly to talk in minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.